Merged
Conversation
kylebarron
commented
Jan 30, 2025
kylebarron
commented
Jan 31, 2025
Member
Author
|
This PR is waiting on #185, which will enable the prefix handling to work out of the box |
kylebarron
commented
Jan 31, 2025
Member
Author
|
@maxrjones what do you think about naming this ? Then it's also less surprising that it delegates to |
new_store functionfrom_url function
Member
I like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90
Todo:
Note: will not read from the environment.Now that we're passing to e.g.S3Store::from_urlit should actually read from the environment! (thanks to Always check env when constructing stores, removefrom_env#189) (note: we need to test this!!)Note: Cannot be used forsignWe may want to vendorparse_url_opts(which is pretty small), so that we can return the Python classes directly, rather than returning aPrefixStore. At least if we switch to storing a prefix store. #184